There are a few edge cases for which the method returns a bad result; !. Comparison of a two NaN 2. Comparison of a two invalid QScriptValue objects will return false instead of true 3. Sometimes QScriptValue::equals print warnings about an invalid engine assignment, but these message are false positive.
Created attachment 57753 [details] Fix v1
Comment on attachment 57753 [details] Fix v1 Wonderful tests. JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp:1124 + equals.reserve(1085); Could this number be calculated?
(In reply to comment #2) > (From update of attachment 57753 [details]) > Wonderful tests. > JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp:1124 > + equals.reserve(1085); > Could this number be calculated? Not really, only the maximal size could be calculated which is permutation of all values in the test. It would be huge. Thanks for review!
Comment on attachment 57753 [details] Fix v1 Clearing flags on attachment: 57753 Committed r60661: <http://trac.webkit.org/changeset/60661>
All reviewed patches have been landed. Closing bug.