Bug 39960 - Broken code generated in GenerateParametersCheckExpressions
Summary: Broken code generated in GenerateParametersCheckExpressions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39962
  Show dependency tree / graph
 
Reported: 2010-05-31 10:16 PDT by Andreas Kling
Modified: 2010-06-01 19:39 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.37 KB, patch)
2010-05-31 10:17 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Proposed patch v2 (3.23 KB, patch)
2010-06-01 04:49 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-05-31 10:16:11 PDT 
The code generated by CodeGeneratorJS.pm (line 1117) will not compile.
Comment 1 Andreas Kling 2010-05-31 10:17:20 PDT 
Created attachment 57478 [details]
Proposed patch
Comment 2 Darin Adler 2010-05-31 10:19:56 PDT 
Comment on attachment 57478 [details]
Proposed patch

I was about to say review+, but what about adding a test case?

Adam Barth has kindly provided us with the run-bindings-tests script. You can add additional test cases to the IDL files in the WebCore/bindings/scripts/test directory, and then use "run-bindings-tests" to see the generated results, then use run-bindings-test --reset-results to generate files that are ready to check in once yu've verified the code is correct.
Comment 3 Andreas Kling 2010-06-01 04:49:51 PDT 
Created attachment 57530 [details]
Proposed patch v2

Right-o, I was not aware of the bindings tests. :-)
Turns out there was already coverage (with a broken reference result.)
Comment 4 WebKit Commit Bot 2010-06-01 19:38:56 PDT 
Comment on attachment 57530 [details]
Proposed patch v2

Clearing flags on attachment: 57530

Committed r60527: <http://trac.webkit.org/changeset/60527>
Comment 5 WebKit Commit Bot 2010-06-01 19:39:03 PDT 
All reviewed patches have been landed.  Closing bug.