Bug 39953 – Web Inspector: support "Continue to Here" in debugger

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Support "Run To Cursor"  functionality in script debugger.

[Timothy Hatcher]

Please describe this, I don't know what this means. (I have some wild guesses but I'll let you go first.)

[Yury Semikhatsky]

It's like a one-time breakpoint. I think it'd be best to describe it as a step in/over/out counterpart that allows to continue program until given statement is reached. When you're debugging a program you may want to inspect its state at some execution point but you might not want to set a regular breakpoint which would cause the program to stop every time when the control flow reaches that line. MS Visual Studio and Eclipse provide such capability, I don't see it in Xcode though.

[Timothy Hatcher]

Ah. Xcode has this, if you right click in the line number column you will see "Continue to Here".

I think Xcode's wording is more clear than "Run To Cursor". Cursor can mean so many things…

[Yury Semikhatsky]

Created attachment 57651 [details]
Patch

[Pavel Feldman]

Comment on attachment 57651 [details]
Patch

Overall, this looks good, so I am open to landing this. However, the change uncovers some problems with our design in the area of passing numerous callbacks into SourceFrame.
As we discussed offline, I would suggest the following refactorings:
1. Make SourceFrame BreakpointManager's listener
1.1. Make SourceFrame responsible for filling breakpoints on creation (few addBreakpoint snippets will go away from ScriptsPanel)
2. Remove sourceFrameForScriptOrResource from the scripts panel.

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 57651 [details])
> Overall, this looks good, so I am open to landing this. However, the change uncovers some problems with our design in the area of passing numerous callbacks into SourceFrame.
> As we discussed offline, I would suggest the following refactorings:
> 1. Make SourceFrame BreakpointManager's listener
> 1.1. Make SourceFrame responsible for filling breakpoints on creation (few addBreakpoint snippets will go away from ScriptsPanel)
> 2. Remove sourceFrameForScriptOrResource from the scripts panel.

Filed a new bug on this: https://bugs.webkit.org/show_bug.cgi?id=40063

[Yury Semikhatsky]

Committed r60567