Bug 39823 - Handle edge cases in HTML5 entity parsing
Summary: Handle edge cases in HTML5 entity parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency tree / graph
 
Reported: 2010-05-27 02:34 PDT by Adam Barth
Modified: 2010-05-28 11:47 PDT (History)
3 users (show)

See Also:

Attachments
Work in progress (12.29 KB, patch)
2010-05-27 02:38 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (13.03 KB, patch)
2010-05-28 03:37 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-27 02:34:05 PDT 
Handle edge cases in HTML5 entity parsing
Comment 1 Adam Barth 2010-05-27 02:38:59 PDT 
Created attachment 57213 [details]
Work in progress
Comment 2 Adam Barth 2010-05-28 03:37:05 PDT 
Created attachment 57312 [details]
Patch
Comment 3 Eric Seidel (no email) 2010-05-28 10:14:26 PDT 
Comment on attachment 57312 [details]
Patch

Should we rip entity handling out into its own class and share code between this and the old tok?

I see a bunch of new failures.  I guess this adds a bunch of tests but doesn't fix them all?
Comment 4 Adam Barth 2010-05-28 10:46:00 PDT 
> Should we rip entity handling out into its own class and share code between this and the old tok?

The problem is that entity handling depends on the state of the lexer.  We could abstract that if we wanted to, however.

> I see a bunch of new failures.  I guess this adds a bunch of tests but doesn't fix them all?

Those are failures in the existing parser.  The new parser passes all the new tests.  (There are two existing entity tests that fail in both the old and new parser, but that's another story.)
Comment 5 Adam Barth 2010-05-28 11:17:20 PDT 
Committed r60369: <http://trac.webkit.org/changeset/60369>