WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
39809
The HTML5 parser shouldn't ASSERT on document.write
https://bugs.webkit.org/show_bug.cgi?id=39809
Summary
The HTML5 parser shouldn't ASSERT on document.write
Adam Barth
Reported
2010-05-26 22:49:04 PDT
The HTML5 parser shouldn't ASSERT on document.write
Attachments
Patch
(2.23 KB, patch)
2010-05-26 22:50 PDT
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-05-26 22:50:55 PDT
Created
attachment 57195
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-05-26 22:53:15 PDT
Comment on
attachment 57195
[details]
Patch OK. Seems reasonable.
Adam Barth
Comment 3
2010-05-26 23:05:43 PDT
Comment on
attachment 57195
[details]
Patch This patch might not be needed after Eric's real ultimate power script patch.
Darin Adler
Comment 4
2010-05-26 23:08:06 PDT
Comment on
attachment 57195
[details]
Patch
> + token = new HTML5Token();
I suggest omitting the parentheses on lines of code like this. I suggest using OwnPtr<HTML5Token> for the local variable too and using swap rather than using a raw pointer and set/release.
Adam Barth
Comment 5
2010-05-26 23:16:24 PDT
Thanks. I'm actually hopeful we won't need this patch if my reading of Eric's patch is correct.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug