RESOLVED FIXED 39649
First cut at HTML5 entities 
https://bugs.webkit.org/show_bug.cgi?id=39649
Summary First cut at HTML5 entities
Adam Barth
Reported 2010-05-24 23:35:32 PDT
First cut at HTML5 entities
Attachments
Patch (20.44 KB, patch)
2010-05-24 23:38 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-24 23:38:26 PDT
Created attachment 56977 [details] Patch
WebKit Review Bot
Comment 2 2010-05-24 23:39:52 PDT
Attachment 56977 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5Lexer.cpp:88: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2010-05-24 23:44:40 PDT
Comment on attachment 56977 [details] Patch LGTM. Style?
Adam Barth
Comment 4 2010-05-24 23:47:25 PDT
Committed r60130: <http://trac.webkit.org/changeset/60130>
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 5 2010-05-25 00:38:54 PDT
s/uncomsumeCharacters/unconsumeCharacters/g?
Note You need to log in before you can comment on or make changes to this bug.