Bug 39649 - First cut at HTML5 entities
Summary: First cut at HTML5 entities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency tree / graph
 
Reported: 2010-05-24 23:35 PDT by Adam Barth
Modified: 2010-05-25 00:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (20.44 KB, patch)
2010-05-24 23:38 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-24 23:35:32 PDT 
First cut at HTML5 entities
Comment 1 Adam Barth 2010-05-24 23:38:26 PDT 
Created attachment 56977 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-24 23:39:52 PDT 
Attachment 56977 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5Lexer.cpp:88:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-05-24 23:44:40 PDT 
Comment on attachment 56977 [details]
Patch

LGTM.  Style?
Comment 4 Adam Barth 2010-05-24 23:47:25 PDT 
Committed r60130: <http://trac.webkit.org/changeset/60130>
Comment 5 Ms2ger (he/him; ⌚ UTC+1/+2) 2010-05-25 00:38:54 PDT 
s/uncomsumeCharacters/unconsumeCharacters/g?