Provide DeviceOrientation LayoutTests
Created attachment 66694 [details]
Hans, did you have any other test cases in mind?
(In reply to comment #2)
> Hans, did you have any other test cases in mind?
This looks very good. Perhaps we should test pushing an orientation through where one or more of the angles is NULL to make sure an implementation doesn't forget to handle that?
Created attachment 66700 [details]
Created attachment 66705 [details]
Updated patch which makes sure we only ever pass boolean or numeric values to layoutTestController.setMockDeviceOrientation().
Hans, if this looks good to you, I'll cq+.
Looks good. Thanks.
Comment on attachment 66705 [details]
Clearing flags on attachment: 66705
Committed r66876: <http://trac.webkit.org/changeset/66876>
All reviewed patches have been landed. Closing bug.