Bug 39590 - Provide DeviceOrientation LayoutTests
Summary: Provide DeviceOrientation LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 39588 39589 43181
Blocks: 30335
  Show dependency tree / graph
 
Reported: 2010-05-24 03:22 PDT by Steve Block
Modified: 2010-09-07 05:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.02 KB, patch)
2010-09-07 01:53 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
Patch (21.11 KB, patch)
2010-09-07 03:22 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
Patch (21.20 KB, patch)
2010-09-07 04:31 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-05-24 03:22:14 PDT 
Provide DeviceOrientation LayoutTests
Comment 1 Steve Block 2010-09-07 01:53:14 PDT 
Created attachment 66694 [details]
Patch
Comment 2 Steve Block 2010-09-07 01:54:31 PDT 
Hans, did you have any other test cases in mind?
Comment 3 Hans Wennborg 2010-09-07 02:25:01 PDT 
(In reply to comment #2)
> Hans, did you have any other test cases in mind?

This looks very good. Perhaps we should test pushing an orientation through where one or more of the angles is NULL to make sure an implementation doesn't forget to handle that?
Comment 4 Steve Block 2010-09-07 03:22:31 PDT 
Created attachment 66700 [details]
Patch
Comment 5 Steve Block 2010-09-07 04:31:42 PDT 
Created attachment 66705 [details]
Patch
Comment 6 Jeremy Orlow 2010-09-07 04:32:56 PDT 
r=me
Comment 7 Steve Block 2010-09-07 04:34:35 PDT 
Updated patch which makes sure we only ever pass boolean or numeric values to layoutTestController.setMockDeviceOrientation().

Hans, if this looks good to you, I'll cq+.
Comment 8 Hans Wennborg 2010-09-07 04:53:02 PDT 
Looks good. Thanks.
Comment 9 WebKit Commit Bot 2010-09-07 05:12:09 PDT 
Comment on attachment 66705 [details]
Patch

Clearing flags on attachment: 66705

Committed r66876: <http://trac.webkit.org/changeset/66876>
Comment 10 WebKit Commit Bot 2010-09-07 05:12:13 PDT 
All reviewed patches have been landed.  Closing bug.