WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39587
Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
https://bugs.webkit.org/show_bug.cgi?id=39587
Summary
Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
Marcus Bulach
Reported
2010-05-24 03:09:06 PDT
Previous change
https://bugs.webkit.org/show_bug.cgi?id=39440
introduced a public dependency on wtf/HashMap.h This prevents WebGeolocationService.h to be included in test_shell. Need to hide this dependency by adding WebGeolocationServiceMockImpl.
Attachments
Patch
(6.19 KB, patch)
2010-05-24 04:18 PDT
,
Marcus Bulach
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Marcus Bulach
Comment 1
2010-05-24 04:18:55 PDT
Created
attachment 56869
[details]
Patch
Kent Tamura
Comment 2
2010-05-24 04:40:39 PDT
Comment on
attachment 56869
[details]
Patch OK
Kent Tamura
Comment 3
2010-05-24 20:59:31 PDT
Comment on
attachment 56869
[details]
Patch I'll land this manually.
Kent Tamura
Comment 4
2010-05-24 21:11:01 PDT
Comment on
attachment 56869
[details]
Patch Clearing flags on attachment: 56869 Committed
r60121
: <
http://trac.webkit.org/changeset/60121
>
Kent Tamura
Comment 5
2010-05-24 21:11:09 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug