Bug 39587 - Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
Summary: Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 03:09 PDT by Marcus Bulach
Modified: 2010-05-24 21:11 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2010-05-24 04:18 PDT, Marcus Bulach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Bulach 2010-05-24 03:09:06 PDT 
Previous change https://bugs.webkit.org/show_bug.cgi?id=39440 introduced a public dependency on wtf/HashMap.h
This prevents WebGeolocationService.h to be included in test_shell.
Need to hide this dependency by adding WebGeolocationServiceMockImpl.
Comment 1 Marcus Bulach 2010-05-24 04:18:55 PDT 
Created attachment 56869 [details]
Patch
Comment 2 Kent Tamura 2010-05-24 04:40:39 PDT 
Comment on attachment 56869 [details]
Patch

OK
Comment 3 Kent Tamura 2010-05-24 20:59:31 PDT 
Comment on attachment 56869 [details]
Patch

I'll land this manually.
Comment 4 Kent Tamura 2010-05-24 21:11:01 PDT 
Comment on attachment 56869 [details]
Patch

Clearing flags on attachment: 56869

Committed r60121: <http://trac.webkit.org/changeset/60121>
Comment 5 Kent Tamura 2010-05-24 21:11:09 PDT 
All reviewed patches have been landed.  Closing bug.