Bug 39440 – [chromium] Adds Geolocation support to DumpRenderTree.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Marcus Bulach]

[chromium] Adds Geolocation support to DumpRenderTree.

[Marcus Bulach]

Created attachment 56620 [details]
Patch

[Kent Tamura]

Comment on attachment 56620 [details]
Patch

Thank you for making the patch.
WebKitTools/DumpRenderTree/chromium is not the primary tester yet.  You need to change webkit/tools/test_shell/ in Chromium too.


WebKit/chromium/public/WebGeolocationServiceMock.h:55
 +      static bool m_mockGeolocationPermission;
We don't prepend "m_" for a static field in WebKit style.


WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1303
 +      WebGeolocationServiceMock::setMockGeolocationError(arguments[0].toInt32(), WebString::fromUTF8(arguments[1].toString()));
nit: We have cppVariantToWebString().


r- for the style error.

[Marcus Bulach]

Created attachment 56691 [details]
Patch

[Marcus Bulach]

thanks Tamura-san!

replies inline:

(In reply to comment #2)
> (From update of attachment 56620 [details])
> Thank you for making the patch.
> WebKitTools/DumpRenderTree/chromium is not the primary tester yet.  You need to change webkit/tools/test_shell/ in Chromium too.

yep, the change has been reviewed and I'll submit it soon:
http://codereview.chromium.org/2094003/show

> 
> 
> WebKit/chromium/public/WebGeolocationServiceMock.h:55
>  +      static bool m_mockGeolocationPermission;
> We don't prepend "m_" for a static field in WebKit style.

Done.

> 
> 
> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1303
>  +      WebGeolocationServiceMock::setMockGeolocationError(arguments[0].toInt32(), WebString::fromUTF8(arguments[1].toString()));
> nit: We have cppVariantToWebString().

ahn, thanks! I went ahead and replaced all occurrences so it won't catch the next reader.
however, please, let me know if you'd prefer to this tidy up in a separate patch, and I'd be happy to revert these changes.

would you mind taking another look? thanks!

> 
> 
> r- for the style error.

[Kent Tamura]

Comment on attachment 56691 [details]
Patch

OK.

[WebKit Commit Bot]

Comment on attachment 56691 [details]
Patch

Clearing flags on attachment: 56691

Committed r60032: <http://trac.webkit.org/changeset/60032>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.