Bug 39546 - webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
Summary: webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-05-22 16:11 PDT by Adam Barth
Modified: 2010-06-02 16:29 PDT (History)
2 users (show)

See Also:

Patch (3.56 KB, patch)
2010-05-22 16:30 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-22 16:11:58 PDT
webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
Comment 1 Adam Barth 2010-05-22 16:30:03 PDT
Created attachment 56796 [details]
Comment 2 Eric Seidel (no email) 2010-05-22 17:36:51 PDT
Comment on attachment 56796 [details]

I'm not sure searching for xcode is a good idea.  Is xed specific to xcode?  In any case Darin Adler should probably review this since this was his request and it might be good for him to see where this code is anyway. :)  the python otherwise looked ok to me.
Comment 3 Adam Barth 2010-05-22 17:44:25 PDT
I think xed is specific to Xcode.

$ xed --help
     -x, --launch                       Just launch Xcode with a new untitled document, don't wait on stdin.
     -c, --create                       Create the files if they do not exist.
     -w, --wait                         Wait for file to be closed by Xcode.
     -l, --line <number>                Select line <number> after opening file.  Takes effect only on last file opened.
     -b, --background                   Leave Xcode as a background app after opening.
     -n, --no-reactivation              After edit with -w, do not re-activate the calling app.
     -h, --help                         Show this information.
     -v, --version                      Print version information.
Comment 4 David Levin 2010-05-28 10:06:17 PDT
Comment on attachment 56796 [details]

Looks good to me.

I know Eric said that it may be good for Darin to look it over but I suspect he has plenty of time to do so by now -- especially given his prodigious review rate, and I'd like to shrink the review queue some. :)
Comment 5 Adam Barth 2010-05-28 10:43:33 PDT
Comment on attachment 56796 [details]

Comment 6 WebKit Commit Bot 2010-05-28 20:06:55 PDT
Comment on attachment 56796 [details]

Clearing flags on attachment: 56796

Committed r60384: <http://trac.webkit.org/changeset/60384>
Comment 7 WebKit Commit Bot 2010-05-28 20:07:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2010-05-31 10:26:18 PDT
I now regret asking for this!

EDITOR set to "xed --wait" gives me great results with webkit-patch.
CHANGE_LOG_EDIT_APPLICATION is still needed to give me good results with prepare-ChangeLog.

Yet if I have both set, then webkit-patch uses CHANGE_LOG_EDIT_APPLICATION instead of EDITOR. That's frustrating. Maybe we should just roll this out? Or maybe we should teach prepare-ChangeLog to use EDITOR? But in that script there is no real benefit to waiting. Any other suggestions?
Comment 9 Adam Barth 2010-06-01 22:19:46 PDT
I'm happy to do whatever you'd prefer.  Sorry for causing trouble.  :(
Comment 10 Darin Adler 2010-06-02 10:04:10 PDT
(In reply to comment #9)
> I'm happy to do whatever you'd prefer.  Sorry for causing trouble.  :(

I really appreciate you doing to the trouble of adding this.

I think it’s probably best to just roll it out again, because there’s probably no one except me who wants it, and setting EDITOR to "xed --launch --wait" is really good for people who want to use Xcode.

By the way, it does need to be “xed --launch --wait”, not just “xed --wait”.
Comment 11 Adam Barth 2010-06-02 16:29:51 PDT
Follow up in