Bug 40088 - webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog
Summary: webkit-patch should use a different editor env variable to avoid conflicting ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 16:26 PDT by Adam Barth
Modified: 2011-06-17 22:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2010-06-02 16:29 PDT, Adam Barth 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-02 16:26:34 PDT 
webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog
Comment 1 Adam Barth 2010-06-02 16:29:35 PDT 
Created attachment 57714 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-02 16:35:26 PDT 
Comment on attachment 57714 [details]
Patch

Why is it _APPLICATION?  Seems should just be _EDITOR since it's actually a terminal program.  xed --launch --wait just is a terminal program which watches XCode.

Otherwise LGTM.
Comment 3 Eric Seidel (no email) 2010-09-02 13:50:07 PDT 
Status?
Comment 4 Adam Barth 2010-09-02 16:02:14 PDT 
I need to address your comments and upload a new version.
Comment 5 Eric Seidel (no email) 2011-01-21 01:37:50 PST 
3-month ping. :)
Comment 6 Adam Barth 2011-06-17 22:58:08 PDT 
Looks like we don't care enough about this patch to land it.  If I'm wrong, please feel free to re-open.