Bug 39356 - [Qt] QScriptValue should have accessors to a prototype.
Summary: [Qt] QScriptValue should have accessors to a prototype.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt, QtTriaged
Depends on: 40060 39360
Blocks: 31863
  Show dependency treegraph
 
Reported: 2010-05-19 06:41 PDT by Jędrzej Nowacki
Modified: 2010-06-25 07:23 PDT (History)
7 users (show)

See Also:


Attachments
Fix v1 (7.74 KB, patch)
2010-06-22 04:40 PDT, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-05-19 06:41:46 PDT
The QScriptValue should have an API to set/get prototype of the value. It should look like this:
http://doc.trolltech.com/4.6/qscriptvalue.html#setPrototype
http://doc.trolltech.com/4.6/qscriptvalue.html#prototype
Comment 1 Jędrzej Nowacki 2010-06-22 04:40:32 PDT
Created attachment 59360 [details]
Fix v1

The accessors are needed to test other QtScript functionality (like a newArray). So I decided to implement them in a suboptimal way. We can fix it as result of discussion on bug 40060 would be known.
Comment 2 WebKit Commit Bot 2010-06-25 06:39:32 PDT
Comment on attachment 59360 [details]
Fix v1

Clearing flags on attachment: 59360

Committed r61860: <http://trac.webkit.org/changeset/61860>
Comment 3 WebKit Commit Bot 2010-06-25 06:39:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-06-25 07:23:42 PDT
http://trac.webkit.org/changeset/61860 might have broken GTK Linux 64-bit Debug