Bug 39335 – Implement the DOCTYPE states for the HTML5 lexer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Implement the DOCTYPE states for the HTML5 lexer

[Adam Barth]

Created attachment 56431 [details]
work in progress

[Adam Barth]

Created attachment 56441 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 56441 [details]
Patch

Totally need an isWhitespace function.

         default:
 1190             ASSERT_NOT_REACHED();
 1191             break;
 1192         }

very bad.  :p  We want the compiler to warn if we're missing an enum value.

[WebKit Review Bot]

Attachment 56441 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5Lexer.cpp:935:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/html/HTML5Lexer.cpp:966:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/html/HTML5Lexer.cpp:1001:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/html/HTML5Lexer.cpp:1115:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/html/HTML5Lexer.cpp:1163:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Committed r59736: <http://trac.webkit.org/changeset/59736>