Bug 39298 - Implement two more lexer states
Summary: Implement two more lexer states
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency tree / graph
 
Reported: 2010-05-18 10:17 PDT by Adam Barth
Modified: 2010-05-18 16:55 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2010-05-18 10:18 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-18 10:17:31 PDT 
Implement two more lexer states
Comment 1 Adam Barth 2010-05-18 10:18:49 PDT 
Created attachment 56387 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-18 10:21:13 PDT 
Attachment 56387 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5Lexer.cpp:661:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-05-18 11:17:58 PDT 
Comment on attachment 56387 [details]
Patch

rs=me.
Comment 4 Adam Barth 2010-05-18 16:55:52 PDT 
Committed r59720: <http://trac.webkit.org/changeset/59720>