RESOLVED FIXED 39277
[Qt] QtScript's JavaScriptCore "out of sync" with QtWebKit's
https://bugs.webkit.org/show_bug.cgi?id=39277
Summary [Qt] QtScript's JavaScriptCore "out of sync" with QtWebKit's
vanboxem.ruben
Reported 2010-05-18 02:39:18 PDT
The files wtf/Platform.h and runtime/Collector.cpp in Qt/src/3rdparty/javascriptcore/JavaScriptCore/ are out of sync with the files in WebKit trunk (and the ones in Qt/src/3rdparty/webkit/JavaScriptCore). How this happened, I don't know, but the update is necessary for QtScript to build with mingw-w32 (<->mingw.org). I tried a Qt merge request(http://qt.gitorious.org/qt/qt/merge_requests/2391), but it seems all has to come through here. The merge request has the needed patch to apply the necessary changes to both files. PS: this is not the "blocker" Win64 JIT bug, this change is from before that. This was the second of the patches applied here: https://bugs.webkit.org/show_bug.cgi?id=35607 (the ... - JavaScriptCore one). Also, the blocker bug has been closed automatically because all the attached patches were landed, the JIT Win64 bug is here now: https://bugs.webkit.org/show_bug.cgi?id=38993 and hesn't been added to the blockers list (is it supposed to be?) Thanks
Attachments
Simon Hausmann
Comment 1 2010-05-18 12:50:52 PDT
This is not blocker for the QtWebKit release, src/3rdparty/javascriptcore is maintained separately.
Benjamin Poulain
Comment 2 2010-05-21 02:49:30 PDT
Kent, is this solved? Can I close this task?
vanboxem.ruben
Comment 3 2010-05-21 02:56:54 PDT
Benjamin Poulain
Comment 4 2010-05-21 03:00:22 PDT
(In reply to comment #3) > http://bugreports.qt.nokia.com/browse/QTBUG-10723 > > The files seem ok to me Cool, closing then.
Note You need to log in before you can comment on or make changes to this bug.