Bug 39137 – Make unsplittable layers (like <video>) position and paginate correctly in multi-column layout.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

Elements like <video> don't work with multi-column layouts, since they don't get positioned properly when they occur in columns 2 or higher.

[Dave Hyatt]

Created attachment 56114 [details]
Patch

[WebKit Review Bot]

Attachment 56114 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/RenderLayer.cpp:3430:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 56114 [details]
Patch

r=me but ideally I'd like to see this split into independent patches.

[Simon Fraser (smfr)]

This may fix bug 25455 and bug 21049.

[Dave Hyatt]

Landed in r59513.

[WebKit Review Bot]

http://trac.webkit.org/changeset/59513 might have broken Qt Linux Release

[Adam Barth]

This patch added a new test that fails on Qt.  Is anyone around to address this issue?

[Adam Barth]

I've skipped the test in Qt in http://trac.webkit.org/changeset/59517.  I have no idea whether we just need a Qt baseline or whether something is really screwed up.

I feel like it's quite inconsiderate to commit at 8pm on a Friday and then disappear without seeing if your patch breaks other ports.

[David Kilzer (:ddkilzer)]

<rdar://problem/7960260>

[Dave Hyatt]

(In reply to comment #8)
> I've skipped the test in Qt in http://trac.webkit.org/changeset/59517.  I have no idea whether we just need a Qt baseline or whether something is really screwed up.
> 
> I feel like it's quite inconsiderate to commit at 8pm on a Friday and then disappear without seeing if your patch breaks other ports.

Wah.

[Dave Hyatt]

I didn't break anything.  There's no bug here.  The test just needs a new result, and I don't run Qt so I can't check it in.