RESOLVED FIXED Bug 21049
Opacity fails in multicolumn layouts
https://bugs.webkit.org/show_bug.cgi?id=21049
Summary Opacity fails in multicolumn layouts
Simon Raboczi
Reported 2008-09-24 01:17:23 PDT
In all but the first column of a multicolumn layout, an opacity less than 1 is displayed as 0. The following markup demonstrates this behavior: <html> <head> <style> body { -webkit-column-count: 2 } div { height: 5000 } span { opacity: 0.5 } </style> </head> <body> <div>Left <span>is dim.</span></div> <div>Right <span>is invisible.</span></div> </body> </html>
Attachments
HTML markup demonstrating different behavior of opacity in second column (219 bytes, text/html)
2008-09-24 01:19 PDT, Simon Raboczi
no flags
Screenshot of multi-col with Opacity:.8 links. (65.39 KB, image/jpeg)
2009-07-08 08:52 PDT, jjm
no flags
Patch (95.95 KB, patch)
2010-05-18 23:23 PDT, Dave Hyatt
no flags
Patch (97.29 KB, patch)
2010-05-19 00:15 PDT, Dave Hyatt
oliver: review+
Simon Raboczi
Comment 1 2008-09-24 01:19:42 PDT
Created attachment 23741 [details] HTML markup demonstrating different behavior of opacity in second column
Simon Fraser (smfr)
Comment 2 2009-07-08 08:45:35 PDT
*** Bug 27069 has been marked as a duplicate of this bug. ***
jjm
Comment 3 2009-07-08 08:52:38 PDT
Created attachment 32454 [details] Screenshot of multi-col with Opacity:.8 links. Attached screenshot shows how webkit renders 1 column, then splits it up. Elements with opacity display as if they were in that one column.
Simon Fraser (smfr)
Comment 4 2009-07-29 08:43:10 PDT
*** Bug 27761 has been marked as a duplicate of this bug. ***
Dave Hyatt
Comment 5 2010-05-14 20:21:45 PDT
r59513 has made this better in that if the content is all contained in a single column it will behave correctly. If it spans multiple columns, however, then it won't render correctly yet.
Dave Hyatt
Comment 6 2010-05-18 23:10:29 PDT
*** Bug 25455 has been marked as a duplicate of this bug. ***
Dave Hyatt
Comment 7 2010-05-18 23:23:13 PDT
WebKit Review Bot
Comment 8 2010-05-18 23:24:50 PDT
Attachment 56462 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderLayer.cpp:2549: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/rendering/RenderLayer.cpp:2996: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 9 2010-05-19 00:15:22 PDT
Oliver Hunt
Comment 10 2010-05-19 13:09:03 PDT
Comment on attachment 56467 [details] Patch r=me I did like the factoring out of hit test and painting logic for the various renderer lists
Dave Hyatt
Comment 11 2010-05-19 14:41:48 PDT
Fixed.
WebKit Review Bot
Comment 12 2010-05-19 16:02:02 PDT
Note You need to log in before you can comment on or make changes to this bug.