Bug 39118 - Touch events are marked DontEnum in DOMWindow.idl
Summary: Touch events are marked DontEnum in DOMWindow.idl
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ben Murdoch
Depends on:
Blocks: 32485
  Show dependency treegraph
Reported: 2010-05-14 08:26 PDT by Ben Murdoch
Modified: 2010-05-19 02:37 PDT (History)
5 users (show)

See Also:

Patch (3.28 KB, patch)
2010-05-17 07:15 PDT, Ben Murdoch
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2010-05-14 08:26:17 PDT
The touch event listener attributes are marked as DontEnum in DOMWindow.idl in contrast to all the other attribute EventListeners. Is this intentional? I propose that we remove the flag from the IDL and make them enumerable for consistency.

I can send a patch if there is agreement.

Comment 1 Ben Murdoch 2010-05-17 07:15:50 PDT
Created attachment 56240 [details]

Here's what the patch would look like. I believe Qt is the only platform that needs the layout test to be updated - AFAIK no other platforms that don't skip this test (e.g. Chromium skip it) have touch events enabled.
Comment 2 Darin Adler 2010-05-17 09:43:03 PDT
Comment on attachment 56240 [details]

OK. r=me
Comment 3 WebKit Commit Bot 2010-05-19 02:37:47 PDT
Comment on attachment 56240 [details]

Clearing flags on attachment: 56240

Committed r59754: <http://trac.webkit.org/changeset/59754>
Comment 4 WebKit Commit Bot 2010-05-19 02:37:52 PDT
All reviewed patches have been landed.  Closing bug.