WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39118
Touch events are marked DontEnum in DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=39118
Summary
Touch events are marked DontEnum in DOMWindow.idl
Ben Murdoch
Reported
2010-05-14 08:26:17 PDT
The touch event listener attributes are marked as DontEnum in DOMWindow.idl in contrast to all the other attribute EventListeners. Is this intentional? I propose that we remove the flag from the IDL and make them enumerable for consistency. I can send a patch if there is agreement. Thanks!
Attachments
Patch
(3.28 KB, patch)
2010-05-17 07:15 PDT
,
Ben Murdoch
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ben Murdoch
Comment 1
2010-05-17 07:15:50 PDT
Created
attachment 56240
[details]
Patch Here's what the patch would look like. I believe Qt is the only platform that needs the layout test to be updated - AFAIK no other platforms that don't skip this test (e.g. Chromium skip it) have touch events enabled.
Darin Adler
Comment 2
2010-05-17 09:43:03 PDT
Comment on
attachment 56240
[details]
Patch OK. r=me
WebKit Commit Bot
Comment 3
2010-05-19 02:37:47 PDT
Comment on
attachment 56240
[details]
Patch Clearing flags on attachment: 56240 Committed
r59754
: <
http://trac.webkit.org/changeset/59754
>
WebKit Commit Bot
Comment 4
2010-05-19 02:37:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug