Bug 38980 - [Qt] Slave losts cause build break on bots.
Summary: [Qt] Slave losts cause build break on bots.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 38969
  Show dependency treegraph
 
Reported: 2010-05-12 02:40 PDT by Csaba Osztrogonác
Modified: 2012-06-12 04:55 PDT (History)
3 users (show)

See Also:


Attachments
proposed fix (1.19 KB, patch)
2010-05-12 02:43 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed fix (1.29 KB, patch)
2010-05-12 03:46 PDT, Csaba Osztrogonác
eric: review-
Details | Formatted Diff | Diff
proposed fix (1.37 KB, patch)
2010-05-12 11:03 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2012-06-12 04:21 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-05-12 02:40:36 PDT
When slave lost (internet connection lost) occured,
the buildbot slave executes a kill -9 command to kill
the build process. 

It cause some 0 byte sized files is build directory which 
won't be recompiled at next build, and we will get link error. 

Only removing 0 byte sized files solve the problem.
Comment 1 Csaba Osztrogonác 2010-05-12 02:43:06 PDT
Created attachment 55821 [details]
proposed fix
Comment 2 Csaba Osztrogonác 2010-05-12 03:46:18 PDT
Created attachment 55827 [details]
proposed fix

Xan noticed me that GTK build has 0 byte sized .dirstamp 
files in builddir shouldn't be deleted before all build.

I modified my patch not to remove any hidden files.

I hope other ports don't have necessary 0 byte sized files. :)
Comment 3 Eric Seidel (no email) 2010-05-12 08:49:22 PDT
Comment on attachment 55827 [details]
proposed fix

It should print out status to the user and explain what it's doing.

I think this code should only run on Gtk for now.
Comment 4 Eric Seidel (no email) 2010-05-12 08:49:34 PDT
Only run on Qt, rather.
Comment 5 Csaba Osztrogonác 2010-05-12 11:03:10 PDT
Created attachment 55871 [details]
proposed fix

I think this cleanup before build might be useful for other 
ports too, but I put it into an isQt() block. In the future
anybody can enable it for other ports.

And now the script dumps which files was removed to stdout.
Comment 6 Csaba Osztrogonác 2010-05-12 13:33:53 PDT
Landed manually: http://trac.webkit.org/changeset/59261
Comment 7 Eric Seidel (no email) 2010-05-12 13:36:26 PDT
Comment on attachment 55871 [details]
proposed fix

I'm not sure thsi really belongs as part of webkit-build, but rather in teh Qt builder config.  But this is OK for now.
Comment 8 Csaba Osztrogonác 2012-06-12 04:20:24 PDT
Reopen to attach a minor fix.
Comment 9 Csaba Osztrogonác 2012-06-12 04:21:37 PDT
Created attachment 147051 [details]
Patch

minor fix
Comment 10 Csaba Osztrogonác 2012-06-12 04:54:51 PDT
Comment on attachment 147051 [details]
Patch

Landed in http://trac.webkit.org/changeset/120060