Bug 38969 - Qt build failures cause SheriffBot false positives
Summary: Qt build failures cause SheriffBot false positives
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 38980
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-11 21:37 PDT by Adam Barth
Modified: 2010-05-12 15:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.67 KB, patch)
2010-05-11 21:40 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff
Add Qt bots back to the core builders (2.31 KB, patch)
2010-05-12 14:33 PDT, Csaba Osztrogonác
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-11 21:37:08 PDT
Qt build failures cause SheriffBot false positives
Comment 1 Eric Seidel (no email) 2010-05-11 21:39:08 PDT
Specifically some sort of 0-sized file after slave lost.  This has been a problem for weeks.
Comment 2 Adam Barth 2010-05-11 21:40:38 PDT
Created attachment 55803 [details]
Patch
Comment 3 Adam Barth 2010-05-11 21:41:34 PDT
From the ChangeLog:

        The Qt buildbot randomly fails to compile occasionally because its 
        network connection causes SVn to leave zero-byte files around.  These 
        compile failures confuse SheriffBot into thinking someone's patch
        caused a build break.

        In this patch, I've temporarily removed Qt from the list of core 
        builders.  Ossy is working on a script to clean up the zero byte files.  
        Once that goes in, we can add Qt back to the core builders.

Hopefully this will be temporary.
Comment 4 Eric Seidel (no email) 2010-05-11 21:42:57 PDT
Comment on attachment 55803 [details]
Patch

OK.
Comment 5 Adam Barth 2010-05-11 21:44:15 PDT
Committed r59207: <http://trac.webkit.org/changeset/59207>
Comment 6 Csaba Osztrogonác 2010-05-12 14:31:52 PDT
0 byte sized files problem fixed: http://trac.webkit.org/changeset/59261
Comment 7 Csaba Osztrogonác 2010-05-12 14:33:57 PDT
Created attachment 55904 [details]
Add Qt bots back to the core builders
Comment 8 Adam Barth 2010-05-12 15:06:49 PDT
Comment on attachment 55904 [details]
Add Qt bots back to the core builders

Yay!
Comment 9 Csaba Osztrogonác 2010-05-12 15:11:26 PDT
(In reply to comment #8)
> (From update of attachment 55904 [details])
> Yay!

Thx, landed: http://trac.webkit.org/changeset/59275