RESOLVED DUPLICATE of bug 125748 38942
Improve check-webkit-style to detect that FeatureDefines.xcconfig is not in sync 
https://bugs.webkit.org/show_bug.cgi?id=38942
Summary Improve check-webkit-style to detect that FeatureDefines.xcconfig is not in sync
Jian Li
Reported 2010-05-11 15:42:03 PDT
All instances of FeatureDefines.xcconfig need to sync up. Otherwise, the build could be broken. See comments from WebCore/Configuration/FeatureDefines.xcconfig. // The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore, // WebCore and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in build-webkit // should match the values below, but they do not need to be in the same order. To avoid this, we could write a script to compare those FeatureDefines.xcconfig and run it from build-webkit. This should make us detect the problem earlier.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-05-12 13:52:04 PDT
See also: http://trac.webkit.org/changeset/59181
Csaba Osztrogonác
Comment 2 2014-02-18 10:56:16 PST
To ensure FeatureDefines.xcconfig files are in sync, the best place is chack-webkit-style. Now they are in sync. If somebody tried to add a change accidentally break it, check-webkit-style or style bot would notice it.
Csaba Osztrogonác
Comment 3 2014-03-12 03:24:41 PDT
*** This bug has been marked as a duplicate of bug 125748 ***
Note You need to log in before you can comment on or make changes to this bug.