Bug 125748 - stylebot should warn when FeatureDefines differ
Summary: stylebot should warn when FeatureDefines differ
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
: 38942 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-14 19:57 PST by Tim Horton
Modified: 2014-03-12 03:24 PDT (History)
7 users (show)

See Also:

Attachments
patch (6.81 KB, patch)
2013-12-14 20:01 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
make stylebot happy :\ (6.78 KB, patch)
2013-12-14 20:09 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-12-14 19:57:01 PST 
I have a patch that makes something like this happen:

ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]
ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]
ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/mac/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]

...if you change only one of the FeatureDefines files. Andy recently got us to zero diffs, so we should keep it that way!
Comment 1 Tim Horton 2013-12-14 20:01:00 PST 
Created attachment 219267 [details]
patch

not sure how kosher the file list is (seems a bit unfortunate) but not sure how else to do it.
Comment 2 WebKit Commit Bot 2013-12-14 20:01:50 PST 
Attachment 219267 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/style/checker.py', u'Tools/Scripts/webkitpy/style/checkers/featuredefines.py', '--commit-queue']" exit_code: 1
ERROR: Tools/Scripts/webkitpy/style/checkers/featuredefines.py:31:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/Scripts/webkitpy/style/checkers/featuredefines.py:62:  no newline at end of file  [pep8/W292] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2013-12-14 20:09:05 PST 
Created attachment 219268 [details]
make stylebot happy :\
Comment 4 WebKit Commit Bot 2013-12-14 20:43:55 PST 
Comment on attachment 219268 [details]
make stylebot happy :\

Clearing flags on attachment: 219268

Committed r160611: <http://trac.webkit.org/changeset/160611>
Comment 5 WebKit Commit Bot 2013-12-14 20:43:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2013-12-16 10:11:26 PST 
I wish we could just push all that stuff into a header file.
Comment 7 Csaba Osztrogonác 2014-03-12 03:24:41 PDT 
*** Bug 38942 has been marked as a duplicate of this bug. ***