Bug 38881 – REGRESSION(r59100): Added test is broken on many platforms

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/59100 broke the build:
"Added test is broken on many platforms." (Requested by eseidel on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 55636 [details]
ROLLOUT of r59100

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Eric Seidel (no email)]

Comment on attachment 55636 [details]
ROLLOUT of r59100

Tree has been red for almost 3 hours and I don't see Jon around, so marking this for rollout.  If you already have a fix in the works, feel free to cq- this.

[Jon Honeycutt]

Comment on attachment 55636 [details]
ROLLOUT of r59100

I'm working on this, so marking the rollout cq-.

[Jon Honeycutt]

Created attachment 55641 [details]
Pach to fix Tiger and Leopard

[Eric Seidel (no email)]

Comment on attachment 55641 [details]
Pach to fix Tiger and Leopard

OK.

[Jon Honeycutt]

Created attachment 55644 [details]
Skip test on Qt and Snow Leopard

[Eric Seidel (no email)]

Comment on attachment 55644 [details]
Skip test on Qt and Snow Leopard

OK.

[Eric Seidel (no email)]

Tiger still fails:
http://build.webkit.org/results/Tiger%20Intel%20Release/r59120%20(11874)/plugins/geturlnotify-during-document-teardown-pretty-diff.html

[James Robinson]

The mac expectations look wrong based on the old tiger and leopard results.  I think there's just an extra newline, but that still means that this test fails on Tiger and Leopard and is skipped on Snow Leopard, Qt and Gtk.  It looks like it's crashing on Windows Debug as well.

[Eric Seidel (no email)]

Created attachment 55652 [details]
Patch

[Eric Seidel (no email)]

Committed r59123: <http://trac.webkit.org/changeset/59123>

[Eric Seidel (no email)]

I've fixed the newline, but I haven't touched windows.  Since windows is not a core builder (and since Jon himself works on the windows port) I'm not going to bother.  However I expect Jon should be able to whip up a fix when he sees his mail.