Bug 38881 - REGRESSION(r59100): Added test is broken on many platforms
Summary: REGRESSION(r59100): Added test is broken on many platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords:
Depends on:
Blocks: 38797
  Show dependency treegraph
 
Reported: 2010-05-10 18:37 PDT by WebKit Review Bot
Modified: 2010-05-10 20:45 PDT (History)
6 users (show)

See Also:


Attachments
ROLLOUT of r59100 (8.20 KB, patch)
2010-05-10 18:37 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff
Pach to fix Tiger and Leopard (3.16 KB, patch)
2010-05-10 19:08 PDT, Jon Honeycutt
no flags Details | Formatted Diff | Diff
Skip test on Qt and Snow Leopard (2.75 KB, patch)
2010-05-10 19:26 PDT, Jon Honeycutt
no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2010-05-10 20:38 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-05-10 18:37:34 PDT
http://trac.webkit.org/changeset/59100 broke the build:
"Added test is broken on many platforms." (Requested by eseidel on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-05-10 18:37:45 PDT
Created attachment 55636 [details]
ROLLOUT of r59100

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Eric Seidel (no email) 2010-05-10 18:39:16 PDT
Comment on attachment 55636 [details]
ROLLOUT of r59100

Tree has been red for almost 3 hours and I don't see Jon around, so marking this for rollout.  If you already have a fix in the works, feel free to cq- this.
Comment 3 Jon Honeycutt 2010-05-10 19:04:32 PDT
Comment on attachment 55636 [details]
ROLLOUT of r59100

I'm working on this, so marking the rollout cq-.
Comment 4 Jon Honeycutt 2010-05-10 19:08:43 PDT
Created attachment 55641 [details]
Pach to fix Tiger and Leopard
Comment 5 Eric Seidel (no email) 2010-05-10 19:12:11 PDT
Comment on attachment 55641 [details]
Pach to fix Tiger and Leopard

OK.
Comment 6 Jon Honeycutt 2010-05-10 19:26:04 PDT
Created attachment 55644 [details]
Skip test on Qt and Snow Leopard
Comment 7 Eric Seidel (no email) 2010-05-10 19:28:59 PDT
Comment on attachment 55644 [details]
Skip test on Qt and Snow Leopard

OK.
Comment 9 James Robinson 2010-05-10 20:31:38 PDT
The mac expectations look wrong based on the old tiger and leopard results.  I think there's just an extra newline, but that still means that this test fails on Tiger and Leopard and is skipped on Snow Leopard, Qt and Gtk.  It looks like it's crashing on Windows Debug as well.
Comment 10 Eric Seidel (no email) 2010-05-10 20:38:00 PDT
Created attachment 55652 [details]
Patch
Comment 11 Eric Seidel (no email) 2010-05-10 20:41:06 PDT
Committed r59123: <http://trac.webkit.org/changeset/59123>
Comment 12 Eric Seidel (no email) 2010-05-10 20:45:20 PDT
I've fixed the newline, but I haven't touched windows.  Since windows is not a core builder (and since Jon himself works on the windows port) I'm not going to bother.  However I expect Jon should be able to whip up a fix when he sees his mail.