Bug 38797 - Crash closing window containing Flash plug-in
Summary: Crash closing window containing Flash plug-in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Jon Honeycutt
URL: http://www.metacafe.com/watch/816714/...
Keywords: InRadar
Depends on: 38881
Blocks:
  Show dependency tree / graph
 
Reported: 2010-05-08 00:03 PDT by Jon Honeycutt
Modified: 2010-05-10 18:37 PDT (History)
4 users (show)

See Also:

Attachments
patch (9.88 KB, patch)
2010-05-08 00:15 PDT, Jon Honeycutt 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2010-05-08 00:03:25 PDT 
Closing a window with the above URL may crash.

<rdar://problem/7935266>
Comment 1 Jon Honeycutt 2010-05-08 00:15:50 PDT 
Created attachment 55464 [details]
patch
Comment 2 WebKit Review Bot 2010-05-08 00:18:33 PDT 
Attachment 55464 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp:109:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp:111:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-05-08 23:21:23 PDT 
Comment on attachment 55464 [details]
patch

Looks sane.
Comment 4 Jon Honeycutt 2010-05-10 15:59:14 PDT 
Landed in r59100.
Comment 5 Eric Seidel (no email) 2010-05-10 16:12:54 PDT 
Looks like this needs to be skipped on Gtk:
http://build.webkit.org/results/Qt%20Linux%20Release/r59100%20(11532)/plugins/geturlnotify-during-document-teardown-pretty-diff.html
Comment 6 WebKit Review Bot 2010-05-10 16:19:26 PDT 
http://trac.webkit.org/changeset/59100 might have broken GTK Linux 32-bit Release and Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/59099
http://trac.webkit.org/changeset/59100