Bug 38710 - Fix guard around IndexedDatabase
Summary: Fix guard around IndexedDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 17:50 PDT by Laszlo Gombos
Modified: 2010-05-08 12:06 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.48 KB, patch)
2010-05-06 17:53 PDT, Laszlo Gombos
kenneth: review-
kenneth: commit-queue-
Details | Formatted Diff | Diff
remove extra ChangeLog (998 bytes, patch)
2010-05-07 14:38 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-05-06 17:50:43 PDT
In PageGroup.h this guard seems incorrect to me:

#if ENABLE(DOM_STORAGE)
        IndexedDatabase* indexedDatabase();
#endif
Comment 1 Laszlo Gombos 2010-05-06 17:53:33 PDT
Created attachment 55326 [details]
proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-05-07 05:52:28 PDT
Comment on attachment 55326 [details]
proposed patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 58924)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,12 @@
> +2010-05-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
> +        https://bugs.webkit.org/show_bug.cgi?id=38706
> +
> +        * WebKit.pro:

This ChangeLog seems to be for another patch!
>
Comment 3 Laszlo Gombos 2010-05-07 14:38:48 PDT
Created attachment 55419 [details]
remove extra ChangeLog
Comment 4 WebKit Commit Bot 2010-05-08 12:05:56 PDT
Comment on attachment 55419 [details]
remove extra ChangeLog

Clearing flags on attachment: 55419

Committed r59034: <http://trac.webkit.org/changeset/59034>
Comment 5 WebKit Commit Bot 2010-05-08 12:06:01 PDT
All reviewed patches have been landed.  Closing bug.