Bug 38706 - [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
Summary: [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-05-06 17:21 PDT by Laszlo Gombos
Modified: 2010-05-08 11:29 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (3.80 KB, patch)
2010-05-06 17:46 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-05-06 17:21:37 PDT
With a few minor changes ImageDiff would build on every Qt supported platforms. Note sure if it make sense to run this on Symbian, but it does not hurt building it.
Comment 1 Laszlo Gombos 2010-05-06 17:46:14 PDT
Created attachment 55324 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-05-06 17:54:51 PDT
Attachment 55324 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/qt/ImageDiff.cpp:20:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2010-05-08 11:29:11 PDT
Comment on attachment 55324 [details]
proposed patch

Clearing flags on attachment: 55324

Committed r59031: <http://trac.webkit.org/changeset/59031>
Comment 4 WebKit Commit Bot 2010-05-08 11:29:17 PDT
All reviewed patches have been landed.  Closing bug.