Bug 38663 - SVGFont's VKern implementation missing
: SVGFont's VKern implementation missing
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: SVG
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Dirk Schulze
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-06 10:46 PDT by Dirk Schulze
Modified: 2010-05-09 23:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (73.56 KB, patch)
2010-05-06 10:59 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (76.44 KB, patch)
2010-05-08 00:22 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-05-06 10:46:06 PDT
SVGFont's VKern implementation missing
Comment 1 Dirk Schulze 2010-05-06 10:59:37 PDT
Created attachment 55269 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-06 11:04:40 PDT
Attachment 55269 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/SVGRootInlineBox.cpp:365:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2010-05-06 11:34:15 PDT
Attachment 55269 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/2227020
Comment 4 WebKit Review Bot 2010-05-06 12:16:14 PDT
Attachment 55269 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2203018
Comment 5 Dirk Schulze 2010-05-08 00:22:00 PDT
Created attachment 55465 [details]
Patch
Comment 6 WebKit Review Bot 2010-05-08 00:26:02 PDT
Attachment 55465 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/SVGRootInlineBox.cpp:365:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dirk Schulze 2010-05-08 01:18:52 PDT
(In reply to comment #6)
> Attachment 55465 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
> exit_code: 1
> WebCore/rendering/SVGRootInlineBox.cpp:365:  Tests for true/false,
> null/non-null, and zero/non-zero should all be done without equality
> comparisons.  [readability/comparison_to_zero] [5]
> Total errors found: 1 in 35 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

The != 0 check is needed here, since the results are allowed to be negative.
Comment 8 Nikolas Zimmermann 2010-05-08 01:43:14 PDT
Comment on attachment 55465 [details]
Patch

Looks fantastic, r=me.
Comment 9 WebKit Review Bot 2010-05-08 02:33:03 PDT
http://trac.webkit.org/changeset/59010 might have broken Qt Linux Release
Comment 10 Eric Seidel 2010-05-08 23:16:26 PDT
Attachment 55465 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Comment 11 Dirk Schulze 2010-05-09 23:05:37 PDT
Comment on attachment 55465 [details]
Patch

Landed in http://trac.webkit.org/changeset/59010.
Buildfix + new Baselines landed in: 59011,59012,59014,59018.
Clearing review flag.