Summary: | SVGFont's VKern implementation missing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||
Component: | SVG | Assignee: | Dirk Schulze <krit> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Dirk Schulze
2010-05-06 10:46:06 PDT
Created attachment 55269 [details]
Patch
Attachment 55269 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/SVGRootInlineBox.cpp:365: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 55269 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2227020 Attachment 55269 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2203018 Created attachment 55465 [details]
Patch
Attachment 55465 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/SVGRootInlineBox.cpp:365: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 35 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #6) > Attachment 55465 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" > exit_code: 1 > WebCore/rendering/SVGRootInlineBox.cpp:365: Tests for true/false, > null/non-null, and zero/non-zero should all be done without equality > comparisons. [readability/comparison_to_zero] [5] > Total errors found: 1 in 35 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. The != 0 check is needed here, since the results are allowed to be negative. Comment on attachment 55465 [details]
Patch
Looks fantastic, r=me.
http://trac.webkit.org/changeset/59010 might have broken Qt Linux Release Attachment 55465 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Comment on attachment 55465 [details] Patch Landed in http://trac.webkit.org/changeset/59010. Buildfix + new Baselines landed in: 59011,59012,59014,59018. Clearing review flag. |