Bug 38615 – [V8] Add V8 bindings for FileReader interface and turn on FileReader support in Chromium

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

[Jian Li]

Add V8 bindings for FileReader interface and turn on FileReader support in Chromium.

[Jian Li]

Created attachment 55180 [details]
Proposed Patch

The ews queue will be broken since this patch depends on 38609 that has not been landed.

[WebKit Review Bot]

Attachment 55180 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/bindings/v8/custom/V8FileReaderCustom.cpp:67:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jian Li]

Created attachment 55184 [details]
Proposed Patch

Style fix.

[WebKit Review Bot]

Attachment 55184 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2175007

[Eric Seidel (no email)]

Why are custom bindings needed?

[Jian Li]

(In reply to comment #5)
> Why are custom bindings needed?

Because we need to get the ScriptExecutionContext and pass it to the FileReader constructor.

[Adam Barth]

> Because we need to get the ScriptExecutionContext and pass it to the FileReader
> constructor.

Have you tried [CallWith=ScriptExecutionContext] ?

[Adam Barth]

Comment on attachment 55184 [details]
Proposed Patch

Please try this without custom bindings.  You might need to extend [CallWith] to work with constructors.

WebCore/bindings/v8/custom/V8FileReaderCustom.cpp:48
 +          return throwError("DOM object custructor cannot be called as a function.");
Which spec does this text come from?  Is this text localized?  I don't think we should have this random custom text in the bindings.

[Jian Li]

We do not need this bug now since we choose to change the code generator to avoid the custom bindings code.