Bug 38609 - Expose FileReader interface
Summary: Expose FileReader interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks: 38615
  Show dependency treegraph
 
Reported: 2010-05-05 14:43 PDT by Jian Li
Modified: 2010-05-11 16:12 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (41.95 KB, patch)
2010-05-05 17:32 PDT, Jian Li
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (42.63 KB, patch)
2010-05-05 17:42 PDT, Jian Li
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (34.63 KB, patch)
2010-05-06 18:15 PDT, Jian Li
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (34.37 KB, patch)
2010-05-06 18:17 PDT, Jian Li
dimich: review-
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (33.03 KB, patch)
2010-05-07 11:31 PDT, Jian Li
dimich: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-05-05 14:43:07 PDT
Need to add FileReader.idl to expose FileReader interface as defined in File API spec (http://www.w3.org/TR/file-upload/#dfn-filereader).
Comment 1 Jian Li 2010-05-05 17:32:40 PDT
Created attachment 55178 [details]
Proposed Patch

This patch contains changes to JSC bindings only.
Comment 2 Jian Li 2010-05-05 17:42:32 PDT
Created attachment 55181 [details]
Proposed Patch

Updated the patch with "--binary" being used for the binary files.
Comment 3 Jian Li 2010-05-06 13:59:37 PDT
Comment on attachment 55181 [details]
Proposed Patch

Will resubmit after the code generator change (38687) is done.
Comment 4 Jian Li 2010-05-06 18:15:05 PDT
Created attachment 55329 [details]
Proposed Patch

Updated the patch since we do not need any custom binding codes now.
Comment 5 Jian Li 2010-05-06 18:17:07 PDT
Created attachment 55331 [details]
Proposed Patch

Forgot to update WebCore/ChangeLog to remove unneeded files.
Comment 6 Dmitry Titov 2010-05-06 19:20:39 PDT
Comment on attachment 55331 [details]
Proposed Patch

Looks great.

One thing - could you please organize the output of the test in such a way as to avoid the file-reader-expected.txt to be a binary file? If it is binary, it will be harder to see in various tools what will change in subsequent changes.
Also, it'd be cool if the patch could pass EWS, less potential troubles this way.

r- to consider the expected file format.
Comment 7 Jian Li 2010-05-07 11:31:30 PDT
Created attachment 55398 [details]
Proposed Patch
Comment 8 Dmitry Titov 2010-05-07 11:39:28 PDT
Comment on attachment 55398 [details]
Proposed Patch

r=me
Comment 9 Jian Li 2010-05-11 16:12:57 PDT
Committed as http://trac.webkit.org/changeset/59162.