Bug 38301 - Change chromium WebViewClient::createView to include WindowFeatures
Summary: Change chromium WebViewClient::createView to include WindowFeatures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 38332
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-28 18:30 PDT by Rafael Weinstein
Modified: 2010-05-02 00:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2010-04-28 18:45 PDT, Rafael Weinstein 		no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2010-04-29 19:18 PDT, Rafael Weinstein 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2010-04-28 18:30:48 PDT 
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=38013 which now additionally passes the WindowFeatures to the WebViewClient::createView method.
Comment 1 Rafael Weinstein 2010-04-28 18:45:33 PDT 
Created attachment 54658 [details]
Patch
Comment 2 WebKit Commit Bot 2010-04-29 03:55:30 PDT 
Comment on attachment 54658 [details]
Patch

Clearing flags on attachment: 54658

Committed r58498: <http://trac.webkit.org/changeset/58498>
Comment 3 WebKit Commit Bot 2010-04-29 03:55:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Dimitri Glazkov (Google) 2010-04-29 09:14:53 PDT 
This broke about a bunch of tests on the canaries. Has the method been hooked up properly downstream?
Comment 5 Rafael Weinstein 2010-04-29 19:18:45 PDT 
Created attachment 54773 [details]
Patch
Comment 6 Rafael Weinstein 2010-04-29 19:21:17 PDT 
The first attempt at landing this patch broke the chromium canary bot because I missed an implementor of WebClientView (TestWebClientDelegate in test_shell).

This has been addressed in http://src.chromium.org/viewvc/chrome?view=rev&revision=46024.
Comment 7 WebKit Commit Bot 2010-05-02 00:23:25 PDT 
Comment on attachment 54773 [details]
Patch

Clearing flags on attachment: 54773

Committed r58643: <http://trac.webkit.org/changeset/58643>
Comment 8 WebKit Commit Bot 2010-05-02 00:23:31 PDT 
All reviewed patches have been landed.  Closing bug.