Bug 38013 - Add an additionalFeatures vector onto WindowFeatures
Summary: Add an additionalFeatures vector onto WindowFeatures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 16:52 PDT by Rafael Weinstein
Modified: 2010-04-23 18:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2010-04-22 16:55 PDT, Rafael Weinstein 		no flags Details | Formatted Diff | Diff
Patch (5.89 KB, patch)
2010-04-22 16:59 PDT, Rafael Weinstein 		no flags Details | Formatted Diff | Diff
Patch (5.98 KB, patch)
2010-04-23 10:46 PDT, Rafael Weinstein 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2010-04-22 16:52:17 PDT 
This patch adds a vector of strings to WindowFeatures which are captured if they are not explicitly observed in WindowFeatures and evaluate to set (value=="yes").

The motivation for this is so that clients (chromium currently) can capture experimental window.open() features.
Comment 1 Rafael Weinstein 2010-04-22 16:55:08 PDT 
Created attachment 54108 [details]
Patch
Comment 2 Rafael Weinstein 2010-04-22 16:59:34 PDT 
Created attachment 54109 [details]
Patch
Comment 3 Darin Fisher (:fishd, Google) 2010-04-23 00:11:31 PDT 
Comment on attachment 54109 [details]
Patch

This is all good, except:

WebKit/chromium/ChangeLog:9
> +          Need a short description and bug URL (OOPS!)
Please delete this line.  Replace it with a link to this bug.

WebCore/ChangeLog:9
> +  
Please include a link to the bug here.

R=me otherwise.  CQ- because this patch needs some tweaks before it can be committed.
Comment 4 Rafael Weinstein 2010-04-23 10:46:59 PDT 
Created attachment 54174 [details]
Patch
Comment 5 Rafael Weinstein 2010-04-23 10:47:44 PDT 
bug link added to both ChangeLogs
Comment 6 WebKit Commit Bot 2010-04-23 18:05:10 PDT 
Comment on attachment 54174 [details]
Patch

Clearing flags on attachment: 54174

Committed r58205: <http://trac.webkit.org/changeset/58205>
Comment 7 WebKit Commit Bot 2010-04-23 18:05:16 PDT 
All reviewed patches have been landed.  Closing bug.