Bug 38122 - check-webkit-style: Rename the processors/ directory to checkers/
Summary: check-webkit-style: Rename the processors/ directory to checkers/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-26 06:08 PDT by Chris Jerdonek
Modified: 2010-04-26 14:03 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (319.61 KB, patch)
2010-04-26 06:18 PDT, Chris Jerdonek
hamaji: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-04-26 06:08:42 PDT
This is to address a FIXME introduced in--

https://bugs.webkit.org/show_bug.cgi?id=37066
Comment 1 Chris Jerdonek 2010-04-26 06:18:43 PDT
Created attachment 54286 [details]
Proposed patch

The only changes that are not the directory move are updating the import statements in checker.py and checker_unittest.py and changing one word in a comment.
Comment 2 WebKit Review Bot 2010-04-26 06:23:53 PDT
Attachment 54286 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 52, in <module>
    import webkitpy.style.checker as checker
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 37, in <module>
    from checkers.common import categories as CommonCategories
ImportError: No module named checkers.common


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Shinichiro Hamaji 2010-04-26 07:04:36 PDT
Comment on attachment 54286 [details]
Proposed patch

Looks like these files were just remoevd :)
Comment 4 Chris Jerdonek 2010-04-26 08:43:22 PDT
(In reply to comment #3)
> (From update of attachment 54286 [details])
> Looks like these files were just remoevd :)

This is a limitation of svn-create-patch.  See for example--

https://bugs.webkit.org/show_bug.cgi?id=35196#c4

Sorry, I thought you knew about this.  Otherwise I would have mentioned that in the comment.  (That's why I put cq-.)
Comment 5 Shinichiro Hamaji 2010-04-26 09:22:36 PDT
Comment on attachment 54286 [details]
Proposed patch

Ah, I didn't know that. Thanks for the info. Looks good, assuming you'll add these files.
Comment 6 Chris Jerdonek 2010-04-26 14:03:04 PDT
Committed: http://trac.webkit.org/changeset/58263