Bug 35196 - Move simplejson into webkitpy/thirdparty directory
Summary: Move simplejson into webkitpy/thirdparty directory
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
Depends on:
Reported: 2010-02-20 11:56 PST by Chris Jerdonek
Modified: 2010-02-20 12:45 PST (History)
4 users (show)

See Also:

Proposed patch (48.24 KB, patch)
2010-02-20 12:07 PST, Chris Jerdonek
abarth: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-02-20 11:56:58 PST
See summary.
Comment 1 Chris Jerdonek 2010-02-20 12:07:25 PST
Created attachment 49132 [details]
Proposed patch

cq- since svn-create-patch does not support svn directory moves.
Comment 2 Chris Jerdonek 2010-02-20 12:08:43 PST
I will fix the typo: simpleson -> simplejson in the ChangeLog.
Comment 3 Adam Barth 2010-02-20 12:19:26 PST
Comment on attachment 49132 [details]
Proposed patch

This change is fine, but I don't think you added the files back...
Comment 4 Chris Jerdonek 2010-02-20 12:36:33 PST
(In reply to comment #3)
> (From update of attachment 49132 [details])
> This change is fine, but I don't think you added the files back...

Thanks again, Adam!

I think the patch looks like that because svn-create-patch doesn't support moving directories.  The svn-create-patch code has the following comment--

# Missing features:
#   Handle copied and moved directories.

I used svn move, and svn status shows the directory being added with history (and the files got moved on my local machine):

svn status
D       WebKitTools/simplejson
D       WebKitTools/simplejson/LICENSE.txt
A  +    WebKitTools/Scripts/webkitpy/thirdparty/simplejson
Comment 5 Chris Jerdonek 2010-02-20 12:45:51 PST
Manually committed using "svn commit" (to preserve history):