Bug 37993 - Assertion failure in AnimationBase::updateStateMachine() coming out of paused state
Summary: Assertion failure in AnimationBase::updateStateMachine() coming out of paused...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords: InRadar
Depends on: 42821
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-22 10:29 PDT by Chris Marrin
Modified: 2010-07-22 07:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.43 KB, patch)
2010-07-21 14:51 PDT, Chris Marrin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2010-04-22 10:29:33 PDT 
This is rare and hard to reproduce, but if you go into pause state when in the AnimationStateStartWaitStyleAvailable, the state of m_pauseTime is incorrect, leading to an assert when coming out of pause state.
Comment 1 Chris Marrin 2010-07-21 11:44:10 PDT 
It's actually easy to reproduce, but you have to use the "pause API" (a feature available in LayoutTests) to get it to happen. You simply run a debug build, start a transition and then pause and unpause. The assert is usually hit. I will try to post a test.
Comment 2 Chris Marrin 2010-07-21 14:49:30 PDT 
It's actually easy to reproduce, but you have to use the "pause API" (a feature available in LayoutTests) to get it to happen. You simply run a debug build, start a transition and then pause and unpause. The assert is usually hit. I will try to post a test.
Comment 3 Chris Marrin 2010-07-21 14:51:03 PDT 
Created attachment 62236 [details]
Patch
Comment 4 Simon Fraser (smfr) 2010-07-21 14:56:02 PDT 
Comment on attachment 62236 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================

> +        https://bugs.webkit.org/show_bug.cgi?id=37993

The bug title should be on the line above the url ("webkit-patch upload" will do this for you).

r=me
Comment 5 Chris Marrin 2010-07-21 16:16:59 PDT 
Patch landed in http://trac.webkit.org/changeset/63862
Comment 6 Csaba Osztrogonác 2010-07-22 06:12:25 PDT 
After this patch animations/play-state.html is flakey on Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r63884%20%2815890%29/animations/play-state-pretty-diff.html

Could you check what the problem is?