RESOLVED FIXED 37953
[Qt] Refactor qtscriptglobal.h 
https://bugs.webkit.org/show_bug.cgi?id=37953
Summary [Qt] Refactor qtscriptglobal.h
Laszlo Gombos
Reported 2010-04-21 14:50:05 PDT
qtscriptglobal.h checks for Q_OS_WIN and Q_OS_SYMBIAN. Checking for Q_OS_SYMBIAN might actually be incorrect for the simulated Symbian environment, but more importantly we should have the same logic for this file as to qwebkitglobal.h (which does not check for Q_OS_SYMBIAN) and leave the knowledge of export rules to Qt itself.
Attachments
proposed patch (1.86 KB, patch)
2010-04-21 16:22 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-04-21 16:22:32 PDT
Created attachment 54002 [details] proposed patch Jedrzej, it would be great if you could test this change in your environment before this gets committed.
Jędrzej Nowacki
Comment 2 2010-04-28 00:36:45 PDT
It works on my Linux machine. Windows build is broken, but it is not because of the patch (35578).
WebKit Commit Bot
Comment 3 2010-04-29 03:25:26 PDT
Comment on attachment 54002 [details] proposed patch Clearing flags on attachment: 54002 Committed r58494: <http://trac.webkit.org/changeset/58494>
WebKit Commit Bot
Comment 4 2010-04-29 03:25:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.