We need to implement ScriptDebugServer for v8. This would allow to have common debugging protocol which wouldn't depend on the underlying JS engine.
Created attachment 53431 [details] patch
Attachment 53431 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Last 3072 characters of output: sorted. [build/include_order] [4] WebCore/bindings/v8/ScriptDebugServer.cpp:62: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:126: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:144: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:174: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:219: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:291: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:292: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:293: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:295: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:298: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:299: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:300: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:301: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:302: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:303: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:304: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:305: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.cpp:306: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:161: Tab found; better to use spaces [whitespace/tab] [1] WebKit/chromium/src/js/DebuggerScript.js:182: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/js/DebuggerScript.js:183: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/js/DebuggerScript.js:184: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/js/DebuggerScript.js:185: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/js/DebuggerScript.js:186: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/js/DebuggerScript.js:187: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/js/DebuggerScript.js:188: Line contains tab character. [whitespace/tab] [5] WebCore/bindings/v8/ScriptDebugServer.h:134: Tab found; better to use spaces [whitespace/tab] [1] WebCore/bindings/v8/ScriptDebugServer.h:135: Tab found; better to use spaces [whitespace/tab] [1] WebKit/chromium/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 34 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 53431 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1683276
Attachment 53431 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1605558
Attachment 53431 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1727007
Created attachment 53434 [details] patch Fixed errors found by try bots.
Attachment 53434 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 53434 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1584495
Created attachment 53435 [details] patch Removed tab from WebCore/ChangeLog
Attachment 53435 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1595517
Comment on attachment 53434 [details] patch Looks good except for "if (jsEngine === "v8")" in InjectedScript.
Created attachment 53439 [details] patch Fixed Chromium compilation issue related to StringHash.h import
Comment on attachment 53439 [details] patch Please explain the InjectedScript fork and the way you are going to resolve it asap (as we discussed offline) in the FIXME. Otherwise looks good.
Created attachment 53453 [details] patch Filed a bug(https://bugs.webkit.org/show_bug.cgi?id=37663) and added FIXME comment with regard to call stack iteration.
Committed r57660
Reverted r57660 for reason: Broke a large number of inspector layout tests in chromium. Committed r57670: <http://trac.webkit.org/changeset/57670>
Committed exactly same patch r57701. The Chromium test failure was related to gyp dependency tracking(see http://code.google.com/p/chromium/issues/detail?id=29695).