Bug 37553 - commit-queue only needs to retry if tests fail (not if apply or build fails)
Summary: commit-queue only needs to retry if tests fail (not if apply or build fails)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 44928 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-04-13 23:29 PDT by Eric Seidel (no email)
Modified: 2010-08-30 20:56 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-04-13 23:29:45 PDT 
commit-queue does not need to try again when a patch fails to apply

Fetching: https://bugs.webkit.org/attachment.cgi?id=53225&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=37493&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 53225 from bug 37493.
Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Maciej Stachowiak', '--force']" exit_code: 1
Cleaning working directory
Building WebKit
Running Python unit tests
Running Perl unit tests
Running JavaScriptCore tests
Running run-webkit-tests
Comment 1 Eric Seidel (no email) 2010-04-14 01:04:23 PDT 
The commit-queue also doesn't need to try again when the commit fails due to checkout out of date.  Or at least it doesn't need to try to confirm that trunk builds.
Comment 2 Eric Seidel (no email) 2010-08-30 20:52:26 PDT 
*** Bug 44928 has been marked as a duplicate of this bug. ***
Comment 3 Eric Seidel (no email) 2010-08-30 20:52:57 PDT 
This caused the commit-queue to hang with a rollout today.  see Bug 44928