Bug 37493 - Finish IPv4 URL parsing test
Summary: Finish IPv4 URL parsing test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 23:26 PDT by Adam Barth
Modified: 2010-04-14 08:13 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.28 KB, patch)
2010-04-12 23:29 PDT, Adam Barth
mjs: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-12 23:26:35 PDT
Finish IPv4 URL parsing test
Comment 1 Adam Barth 2010-04-12 23:29:08 PDT
Created attachment 53225 [details]
Patch
Comment 2 Maciej Stachowiak 2010-04-12 23:33:29 PDT
Comment on attachment 53225 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2010-04-14 03:02:46 PDT
Comment on attachment 53225 [details]
Patch

Rejecting patch 53225 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Maciej Stachowiak', '--force']" exit_code: 1
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/url/ipv4-expected.txt
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/url/ipv4-expected.txt.rej
patching file LayoutTests/fast/url/script-tests/ipv4.js
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 7.
Hunk #3 FAILED at 16.
3 out of 3 hunks FAILED -- saving rejects to file LayoutTests/fast/url/script-tests/ipv4.js.rej

Full output: http://webkit-commit-queue.appspot.com/results/1628490
Comment 4 Adam Barth 2010-04-14 08:13:54 PDT
I think I landed this by hand.