Bug 37381 - [Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
Summary: [Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compos...
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 35866
  Show dependency treegraph
 
Reported: 2010-04-10 00:33 PDT by Csaba Osztrogonác
Modified: 2010-05-14 08:46 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-04-10 00:33:53 PDT
animations/dynamic-stylesheet-loading.html introduced in http://trac.webkit.org/changeset/57390 ,
but fails if accelerated compositing is enabled (enabled by default)

results: http://build.webkit.org/results/Qt%20Linux%20Release/r57407%20%289904%29/results.html

If I disabled accelerated compositing, the test would be pass: (r57365)
--- a/WebKit/qt/Api/qwebsettings.cpp
+++ b/WebKit/qt/Api/qwebsettings.cpp
@@ -451,7 +451,7 @@ QWebSettings::QWebSettings()
     d->attributes.insert(QWebSettings::LocalStorageEnabled, false);
     d->attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls, false);
     d->attributes.insert(QWebSettings::LocalContentCanAccessFileUrls, true);
-    d->attributes.insert(QWebSettings::AcceleratedCompositingEnabled, true);
+    d->attributes.insert(QWebSettings::AcceleratedCompositingEnabled, false);
Comment 1 Csaba Osztrogonác 2010-04-10 00:46:52 PDT
It might be related with: https://bugs.webkit.org/show_bug.cgi?id=36191

Skipped until fix: http://trac.webkit.org/changeset/57409
Comment 2 Jocelyn Turcotte 2010-05-06 06:53:00 PDT
We should try to un-skip this test as soon as possible: P1.
Comment 3 Noam Rosenthal 2010-05-09 03:11:10 PDT
I can't reproduce it - I believe it was fixed as a side effect of http://trac.webkit.org/changeset/57961. Can someone double check?
Comment 4 Csaba Osztrogonác 2010-05-14 06:05:34 PDT
(In reply to comment #3)
> I can't reproduce it - I believe it was fixed as a side effect of http://trac.webkit.org/changeset/57961. Can someone double check?

I double checked, it works now, so I unskipped it:
http://trac.webkit.org/changeset/59471
Comment 5 Simon Hausmann 2010-05-14 08:43:36 PDT
<cherry-pick-for-backport: r59471>
Comment 6 Simon Hausmann 2010-05-14 08:46:49 PDT
Revision r59471 cherry-picked into qtwebkit-2.0 with commit 4696beb87359fe9236d23e0791526eb38dab341d