Bug 35866 – [Qt] Enable accelerated compositing by default

• Status: CLOSED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] Enable accelerated compositing by default

[Simon Hausmann]

Created attachment 50220 [details]
Patch

[Simon Hausmann]

Noam, could you also take a quick look at this patch and double check the "documentation" I've added?

Thanks :)

[Noam Rosenthal]

I'd also maybe add a word about 3D and video? without AC the perspective attribute doesn't render at all, and the video tag makes WebCore render for each frame. So there are some UIs that are only achievable with AC, regardless of performance.
Otherwise LGTM

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords

[Kenneth Rohde Christiansen]

Comment on attachment 50220 [details]
Patch

Looks good, but a follow up patch is needed to the QtLauncher.

[WebKit Commit Bot]

Comment on attachment 50220 [details]
Patch

Clearing flags on attachment: 50220

Committed r55955: <http://trac.webkit.org/changeset/55955>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

This patch broke 3 animation test, so I had to roll-out. (http://trac.webkit.org/changeset/55963)

detailed results:
http://build.webkit.org/results/Qt%20Linux%20Release/r55955%20%288504%29/results.html

[Kenneth Rohde Christiansen]

I cq'ed 2 other patches providing fixed to AC. When these land, could you retest with this patch?

It would be nice to have this enabled by default so that we can actually make sure that our AC works as expected.

[Csaba Osztrogonác]

(In reply to comment #9)
> I cq'ed 2 other patches providing fixed to AC. When these land, could you
> retest with this patch?
I retested r55970 with this patch, but unfortunately the three animation test still fail.

[Jesus Sanchez-Palencia]

Is this Mac OS specific?
If not, could you please change the OS so we don't add another item to the Mac specific bugs list?

(I can't edit the bugzilla entry, otherwise I would edit this.)

[Csaba Osztrogonác]

(In reply to comment #11)
> Is this Mac OS specific?
No, I changed it.

[Csaba Osztrogonác]

Created attachment 50840 [details]
enable AC, skip failing tests

Kenneth told me on #qtwebkit that enabling AC is 
more important than these three failing tests now,
so we can enable AC, and skip them until fix.

Thank for Noam to file another bug for fixing these tests.

[Csaba Osztrogonác]

Comment on attachment 50840 [details]
enable AC, skip failing tests

I landed it manually, because CQ didin't work for a day:
http://trac.webkit.org/changeset/56106

[Jesus Sanchez-Palencia]

Follow up patch for QtLauncher is here:
https://bugs.webkit.org/show_bug.cgi?id=36234

[Simon Hausmann]

*** Bug 35522 has been marked as a duplicate of this bug. ***

[Kenneth Rohde Christiansen]

Can this bug be closed? or what is missing?

[Csaba Osztrogonác]

(In reply to comment #17)
> Can this bug be closed? or what is missing?

Fixing the 3 tests was broken by enabling AC is missing:
https://bugs.webkit.org/show_bug.cgi?id=36191

From now this bug depends on b36191, I suggest we shouldn't close it until fix.

[Kenneth Rohde Christiansen]

Can we close this one? or what is missing?

[Csaba Osztrogonác]

(In reply to comment #19)
> Can we close this one? or what is missing?
Yes, because all test work and are unskipped now.

[Simon Hausmann]

Revision r55955 cherry-picked into qtwebkit-2.0 with commit 75fb772135fa93687ef31e76224d0d5b3c0bbd5f