Bug 37231 - [chromium] Move GraphicsLayer-related files from platform/graphics/skia to platform/graphics/chromium
Summary: [chromium] Move GraphicsLayer-related files from platform/graphics/skia to pl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-07 14:21 PDT by Vangelis Kokkevis
Modified: 2010-04-10 22:03 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (100.78 KB, patch)
2010-04-07 14:53 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-04-07 14:21:09 PDT
Classes in these files have already been renamed in:

https://bugs.webkit.org/show_bug.cgi?id=37116

and they now should be moved to their final location.  Files are moving out of Skia as they will be used with both Skia (Windows/Linux) and CG (mac) based RenderContext's.
Comment 1 Vangelis Kokkevis 2010-04-07 14:53:19 PDT
Created attachment 52786 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-04-07 14:56:49 PDT
Attachment 52786 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: Skipping non-existent file: WebCore/platform/graphics/skia/LayerRendererSkia.h
WARNING: Skipping non-existent file: WebCore/platform/graphics/skia/GraphicsLayerSkia.cpp
WebCore/platform/graphics/chromium/LayerChromium.h:72:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:75:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:78:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:81:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:84:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:90:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:93:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:96:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:99:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:105:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:119:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:122:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:125:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:129:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/chromium/LayerChromium.h:150:  More than one command on the same line  [whitespace/newline] [4]
WARNING: Skipping non-existent file: WebCore/platform/graphics/skia/GraphicsLayerSkia.h
WARNING: Skipping non-existent file: WebCore/platform/graphics/skia/LayerRendererSkia.cpp
WARNING: Skipping non-existent file: WebCore/platform/graphics/skia/LayerSkia.h
WARNING: Skipping non-existent file: WebCore/platform/graphics/skia/LayerSkia.cpp
Total errors found: 15 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Vangelis Kokkevis 2010-04-08 15:05:39 PDT
I believe all the style warnings are false positives for multiple commands on the same line in inline method definitions in a header.  This CL merely moves and renames files but doesn't change their contents (other than adjusting the #include's).
Comment 4 Dimitri Glazkov (Google) 2010-04-08 15:59:19 PDT
Comment on attachment 52786 [details]
Proposed patch

ok.
Comment 5 Vangelis Kokkevis 2010-04-09 17:11:29 PDT
Dimitri,
 Can you please flip the commit queue bit when you get a chance? 
Thanks!
Comment 6 WebKit Commit Bot 2010-04-10 22:03:18 PDT
Comment on attachment 52786 [details]
Proposed patch

Clearing flags on attachment: 52786

Committed r57436: <http://trac.webkit.org/changeset/57436>
Comment 7 WebKit Commit Bot 2010-04-10 22:03:24 PDT
All reviewed patches have been landed.  Closing bug.