Bug 37116 - [chromium] Rename graphics layer specific classes from *Skia to *Chromium
Summary: [chromium] Rename graphics layer specific classes from *Skia to *Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-05 15:21 PDT by Vangelis Kokkevis
Modified: 2010-04-06 16:47 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (50.59 KB, patch)
2010-04-05 17:47 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff
Fixing first webkit style issue. (50.57 KB, patch)
2010-04-05 18:21 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-04-05 15:21:39 PDT
The renaming of classes is done in preparation for moving the code from platform/graphics/skia to platform/graphics/chromium as the layer compositor code will be very similar across all platforms, whether we're using Skia or CG.

The classes affected are:
LayerSkia -> LayerChromium
LayerRendererSkia -> LayerRendererChromium
GraphicsLayerSkia -> GraphicsLayerChromium
Comment 1 Vangelis Kokkevis 2010-04-05 17:47:21 PDT
Created attachment 52591 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-04-05 17:52:37 PDT
Attachment 52591 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/skia/LayerRendererSkia.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/skia/LayerSkia.h:72:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/skia/LayerSkia.h:125:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Vangelis Kokkevis 2010-04-05 18:21:54 PDT
Created attachment 52593 [details]
Fixing first webkit style issue. 

I've been previously told that the "More than one command on the same line" warnings are a result of a bug in the style checker so I'm not modifying those lines.
Comment 4 WebKit Review Bot 2010-04-05 18:26:14 PDT
Attachment 52593 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/skia/LayerSkia.h:72:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/graphics/skia/LayerSkia.h:125:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dimitri Glazkov (Google) 2010-04-06 08:40:56 PDT
Comment on attachment 52593 [details]
Fixing first webkit style issue. 

looks great!
Comment 6 WebKit Commit Bot 2010-04-06 16:17:08 PDT
Comment on attachment 52593 [details]
Fixing first webkit style issue. 

Clearing flags on attachment: 52593

Committed r57176: <http://trac.webkit.org/changeset/57176>
Comment 7 WebKit Commit Bot 2010-04-06 16:17:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-04-06 16:47:11 PDT
http://trac.webkit.org/changeset/57176 might have broken SnowLeopard Intel Release (Tests)