Bug 37217 - Add skeleton FileStream module for providing sync file operations for FileAPI
Summary: Add skeleton FileStream module for providing sync file operations for FileAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32624 36567 37218
  Show dependency tree / graph
 
Reported: 2010-04-07 10:26 PDT by Kinuko Yasuda
Modified: 2010-04-07 13:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.37 KB, patch)
2010-04-07 10:35 PDT, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
Patch (17.79 KB, patch)
2010-04-07 11:26 PDT, Kinuko Yasuda 		jianli: review+
jianli: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-04-07 10:26:17 PDT 
We need a platform-independent module that supports synchronous file operations for FileAPI.  The operations provided by FileStream are supposed to run on worker or file threads.
Comment 1 Kinuko Yasuda 2010-04-07 10:35:55 PDT 
Created attachment 52750 [details]
Patch
Comment 2 Jian Li 2010-04-07 10:53:33 PDT 
Comment on attachment 52750 [details]
Patch

You need to add new files to other projects, like the following:
  WebCore.vcproj/WebCore.vcproj
  WebCore.gypi
  WebCore.pro
  GNUmakefile.am

Also you do not need to list all the new methods for the new files in ChangeLog.
Comment 3 Kinuko Yasuda 2010-04-07 11:26:11 PDT 
Created attachment 52759 [details]
Patch
Comment 4 Kinuko Yasuda 2010-04-07 11:37:37 PDT 
Comment on attachment 52759 [details]
Patch

Thanks, updated the patch (so did I for 37218).
Comment 5 Jian Li 2010-04-07 13:20:45 PDT 
Comment on attachment 52759 [details]
Patch

Looks good. Need to land it manually due to potential xcodeproj conflict when applying the patch.

r=me
Comment 6 Jian Li 2010-04-07 13:50:30 PDT 
Landed for kinuko at http://trac.webkit.org/changeset/57229.