RESOLVED FIXED37065
check-webkit-style: decouple the StyleChecker class and error_handlers.py from patch-related code 
https://bugs.webkit.org/show_bug.cgi?id=37065
Summary check-webkit-style: decouple the StyleChecker class and error_handlers.py fro...
Chris Jerdonek
Reported 2010-04-03 14:28:01 PDT
checker.py and error_handlers.py shouldn't have to know how to parse and interpret patches.
Attachments
Proposed patch (8.58 KB, patch)
2010-04-11 13:07 PDT, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-04-03 15:40:06 PDT
We can probably get rid of the PatchStyleErrorHandler altogether by renaming the DefaultStyleErrorHandler to StyleErrorHandler and having it accept an optional array of line numbers (the line numbers of the modified lines). We probably also want to move the style_checker.check_patch() method to style/main.py and have the style_checker.check_file() method accept an optional array of line numbers, similar to the above. This way only style/main.py needs to be aware of patch-related code. This will have other benefits for future patches as well.
Chris Jerdonek
Comment 2 2010-04-11 13:07:57 PDT
Created attachment 53098 [details] Proposed patch
Chris Jerdonek
Comment 3 2010-04-11 13:10:09 PDT
This report was originally to move the patch-related code to a separate file, but for now it would be sufficient and better simply to move that code into a separate class.
Shinichiro Hamaji
Comment 4 2010-04-11 20:40:46 PDT
Comment on attachment 53098 [details] Proposed patch Looks sane.
WebKit Commit Bot
Comment 5 2010-04-11 20:53:06 PDT
Comment on attachment 53098 [details] Proposed patch Clearing flags on attachment: 53098 Committed r57467: <http://trac.webkit.org/changeset/57467>
WebKit Commit Bot
Comment 6 2010-04-11 20:53:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.