Bug 37063 - Tighten SheriffBot's flaky test detector
Summary: Tighten SheriffBot's flaky test detector
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on: 36911
  Show dependency treegraph
Reported: 2010-04-03 14:01 PDT by Adam Barth
Modified: 2010-05-17 01:44 PDT (History)
2 users (show)

See Also:

Patch (12.51 KB, patch)
2010-04-03 14:08 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (13.61 KB, patch)
2010-04-05 00:24 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-03 14:01:40 PDT
Tighten SheriffBot's flaky test detector
Comment 1 Adam Barth 2010-04-03 14:08:20 PDT
Created attachment 52500 [details]
Comment 2 Adam Barth 2010-04-04 09:56:07 PDT
Need to add "Tests that caused the DumpRenderTree tool to crash:" as a results key.
Comment 3 Eric Seidel (no email) 2010-04-04 23:27:30 PDT
This patch really wants bug 36911 to be landed first. :)
Comment 4 Adam Barth 2010-04-05 00:24:02 PDT
Created attachment 52518 [details]
Comment 5 Adam Barth 2010-04-05 00:25:00 PDT
Committed r57065: <http://trac.webkit.org/changeset/57065>
Comment 6 Adam Barth 2010-04-05 00:25:58 PDT
Sorry for landing this change unreviewed.  I pulled over the relevant code from Bug 36911.  I'm leaving this bug open so Eric can give me an after-the-fact review when he wakes up.
Comment 7 Eric Seidel (no email) 2010-04-05 14:00:52 PDT
Comment on attachment 52518 [details]

This really wanted bug 36911, since this is basicaly a re-write of that logic. :(

test_no_results is wrong.

Otherwise looks OK.
Comment 8 Daniel Bates 2010-05-17 00:56:29 PDT
What is the status with this bug? Can we close it?