Add webkit-patch command to crawl buildbot history and find when tests started to fail
Created attachment 52228 [details]
+ raise "Unhandled title: %s" % str(table_title)
We should only be raising Exception objects. Better to raise an Exception().
+ def _print_blame_information_for_commit(tool, commit_info):
This should be in a base class? Maybe on CommitInfo? Having a random global function seems strange.
+ class FailureReason(AbstractDeclarativeCommand):
This class is kind of lame. It makes it really hard to re-use this logic or to test it. Maybe we need a FailureWalker class?
Created attachment 52696 [details]
Updated it so it applies to TOT. Haven't bothered to abstract out the build-walker stuff.
Created attachment 52704 [details]
Comment on attachment 52704 [details]
Ok. Let's take this as a starting point. As you noted in the other bug, there's a lot of overlap with the algorithm the sheriff uses to track recent regressions. This code looks like it understands more cases (e.g., >= 20 failures). We should find a way to unify and abstract out the different pieces,but I don't want to hold this patch hostage any longer.
Committed r57195: <http://trac.webkit.org/changeset/57195>