Bug 36936 - Factor DocumentSwitcher out of FrameLoader
Summary: Factor DocumentSwitcher out of FrameLoader
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 29947
  Show dependency treegraph
Reported: 2010-04-01 00:10 PDT by Adam Barth
Modified: 2011-06-12 06:19 PDT (History)
2 users (show)

See Also:

Work in progress (does not compile) (20.38 KB, patch)
2010-04-01 00:11 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
More work in progress (33.36 KB, patch)
2010-04-05 16:33 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-01 00:10:15 PDT
FrameLoader does many things.  One of its core responsibilities is to switch around m_documentLoader, m_provisionalDocumentLoader, and m_policyDocumentLoader.  Unlike my previous patches (which moved "front-end" code out of FrameLoader), this patch will move "back-end" code out of FrameLoader.

DocumentSwitcher is intended to encapsulate write access to the document loaders as well as m_state, as distinct from the various load* methods of FrameLoader (which are closer to the front of the loading pipeline).
Comment 1 Adam Barth 2010-04-01 00:11:13 PDT
Created attachment 52266 [details]
Work in progress (does not compile)
Comment 2 Sam Weinig 2010-04-01 17:50:40 PDT
I love it! But can you move it to a new file.
Comment 3 Adam Barth 2010-04-01 18:10:47 PDT
Sure.  :)
Comment 4 Adam Barth 2010-04-05 16:33:55 PDT
Created attachment 52588 [details]
More work in progress
Comment 5 Adam Barth 2010-04-05 16:34:25 PDT
I realized that m_loadType should move back to FrameLoader.  Turns out FrameLoader is very complicated.