Bug 36811 - [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
Summary: [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 01:21 PDT by Fumitoshi Ukai
Modified: 2010-03-30 02:27 PDT (History)
0 users

See Also:

Attachments
Patch (2.11 KB, patch)
2010-03-30 01:29 PDT, Fumitoshi Ukai 		hamaji: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2010-03-30 01:21:29 PDT 
[ RUN      ] WorkerTest.WorkerWebSocketLayoutTests
No handlers could be found for logger "webkitpy.layout_tests.port.websocket_server"
Traceback (most recent call last):
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 312, in ?
    pywebsocket.stop(force=True)
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 253, in stop
    self._port_obj._kill_process(pid)
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\chromium_win.py", line 124, in _kill_process
    stderr=subprocess.PIPE)
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 413, in call
    return Popen(*args, **kwargs).wait()
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 534, in __init__
    (p2cread, p2cwrite,
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 594, in _get_handles
    p2cread = self._make_inheritable(p2cread)
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 635, in _make_inheritable
    DUPLICATE_SAME_ACCESS)
TypeError: an integer is required
c:\b\slave\win\build\src\chrome\test\ui\ui_layout_test.cc(39): error: Value of: file_util::DieFileDie(temp_test_dir_, true)
  Actual: false
Expected: true
[  FAILED  ] WorkerTest.WorkerWebSocketLayoutTests (15328 ms)

I believe this is the same as https://bugs.webkit.org/show_bug.cgi?id=36586
Comment 1 Fumitoshi Ukai 2010-03-30 01:29:13 PDT 
Created attachment 52012 [details]
Patch
Comment 2 Fumitoshi Ukai 2010-03-30 02:27:38 PDT 
Committed r56774: <http://trac.webkit.org/changeset/56774>