On Chromium-Win, websocket_server.py failed to start the server. http://build.chromium.org/buildbot/try-server/builders/win/builds/24808/steps/ui_tests/logs/stdio [ RUN ] WorkerTest.WorkerWebSocketLayoutTests No handlers could be found for logger "webkitpy.layout_tests.port.websocket_server" Traceback (most recent call last): File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 308, in ? pywebsocket.start() File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 205, in start env=env) File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 534, in __init__ (p2cread, p2cwrite, File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 594, in _get_handles p2cread = self._make_inheritable(p2cread) File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 635, in _make_inheritable DUPLICATE_SAME_ACCESS) TypeError: an integer is required
Created attachment 51617 [details] Patch
(In reply to comment #1) > Created an attachment (id=51617) [details] > Patch With this patch, chromium tests passes on Win. http://build.chromium.org/buildbot/try-server/builders/win/builds/24835 http://build.chromium.org/buildbot/try-server/builders/win/builds/24835/steps/gclient/logs/patch http://build.chromium.org/buildbot/try-server/builders/win/builds/24835/steps/ui_tests/logs/stdio
Comment on attachment 51617 [details] Patch Looks good! But please add a few more information into ChangeLog before you submit. > + * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin It would be better to describe why this change fixes the issue.
Committed r56614: <http://trac.webkit.org/changeset/56614>