Bug 36586 - [Chromium-Win] websocket_server.py failed to start
Summary: [Chromium-Win] websocket_server.py failed to start
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Fumitoshi Ukai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 02:16 PDT by Fumitoshi Ukai
Modified: 2010-03-26 01:45 PDT (History)
0 users

See Also:


Attachments
Patch (1.44 KB, patch)
2010-03-25 03:29 PDT, Fumitoshi Ukai
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2010-03-25 02:16:40 PDT
On Chromium-Win, websocket_server.py failed to start the server.
http://build.chromium.org/buildbot/try-server/builders/win/builds/24808/steps/ui_tests/logs/stdio

[ RUN      ] WorkerTest.WorkerWebSocketLayoutTests
No handlers could be found for logger "webkitpy.layout_tests.port.websocket_server"
Traceback (most recent call last):
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 308, in ?
    pywebsocket.start()
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 205, in start
    env=env)
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 534, in __init__
    (p2cread, p2cwrite,
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 594, in _get_handles
    p2cread = self._make_inheritable(p2cread)
  File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 635, in _make_inheritable
    DUPLICATE_SAME_ACCESS)
TypeError: an integer is required
Comment 1 Fumitoshi Ukai 2010-03-25 03:29:07 PDT
Created attachment 51617 [details]
Patch
Comment 3 Shinichiro Hamaji 2010-03-26 00:51:31 PDT
Comment on attachment 51617 [details]
Patch

Looks good! But please add a few more information into ChangeLog before you submit.

> +        * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin

It would be better to describe why this change fixes the issue.
Comment 4 Fumitoshi Ukai 2010-03-26 01:45:42 PDT
Committed r56614: <http://trac.webkit.org/changeset/56614>